Build openid on ruby1.8:#278

Steps and Logfiles:

1. darcs [update]
   1. stdio
2. test [828 tests 6505 assertions]
   1. stdio

Blamelist:

1. Kevin Turner <kevin@janrain.com>
2. chowells@janrain.com
3. cygnus@janrain.com
4. dag@janrain.com

All Changes

1. Changed by: chowells@janrain.com
   Changed at: Fri 11 Jul 2008 15:10:35
   Branch: 2.x.x
   Revision: 20080711220805-05081-932bed38b0adc6c6dd102532e2c486c0bc529aac.gz
   
   Changed files:

   • lib/openid/server.rb
   Comments:

   Fix logic error caused by strange ruby precedence rules
   

2. Changed by: dag@janrain.com
   Changed at: Thu 05 Jun 2008 12:08:01
   Branch: 2.x.x
   Revision: 20080605190641-bc242-435846d928be4448ff39496605491c087c831c43.gz
   
   Changed files:

   • lib/openid/trustroot.rb
   Comments:

   Don't silently fail when trustroot.parse is passed a crazy argument
   

3. Changed by: dag@janrain.com
   Changed at: Wed 04 Jun 2008 16:50:27
   Branch: 2.x.x
   Revision: 20080604234910-bc242-f4ad0a07e1a4fb3d66791b704c234394ed13b67a.gz
   
   Changed files:

   • lib/openid/server.rb
   • test/test_server.rb
   Comments:

   Handle trust_root = '' the same as trust_root missing
   

4. Changed by: chowells@janrain.com
   Changed at: Fri 06 Jun 2008 10:14:59
   Branch: 2.x.x
   Revision: 20080604232208-05081-70ede6cce2293e81d7073aa0bba5b459cb8c0091.gz
   
   Changed files:

   • lib/openid/server.rb
   • test/test_server.rb
   Comments:

   #220 server.rb Fix to_form_markup to use the return_to frrom the request
   

5. Changed by: dag@janrain.com
   Changed at: Wed 04 Jun 2008 17:10:07
   Branch: 2.x.x
   Revision: 20080605000754-bc242-0bae4a383f2a1e990c0f5d37d1adb02feec97809.gz
   
   Changed files:

   • lib/openid/message.rb
   • lib/openid/server.rb
   • test/test_message.rb
   Comments:

   message: raise a special exception for invalid openid.ns
   

6. Changed by: cygnus@janrain.com
   Changed at: Wed 11 Jun 2008 11:29:08
   Branch: 2.x.x
   Revision: 20080611182725-32594-a92787a80d05a309a1f03242eb6ae4dd7bf5a567.gz
   
   Changed files:

   • admin/fixperms
   Comments:

   admin/fixperms: Fix stale entries
   

7. Changed by: dag@janrain.com
   Changed at: Thu 05 Jun 2008 15:51:16
   Branch: 2.x.x
   Revision: 20080605224937-bc242-f4a4a8e4b392ab07c0954d89b46d805b88d7575a.gz
   
   Changed files:

   • lib/openid/server.rb
   • test/test_server.rb
   • test/test_sreg.rb
   Comments:

   Deprecate server.CheckIDRequest.namespace and stop using == OPENID1_NS anywhere in server
   

8. Changed by: Kevin Turner <kevin@janrain.com>
   Changed at: Fri 27 Jun 2008 15:30:06
   Branch: 2.x.x
   Revision: 20080627220135-04611-2dabaf15057d28daa98e9c5b587222186dfbe868.gz
   
   Changed files:

   • lib/openid/util.rb
   Comments:

   util: remove call to srand
   
   From the Ruby FAQ:
   
   9.2 How do random number seeds work?
   
   It depends. In Ruby versions prior to 1.5.2, the random number generator had
   (by default) a constant seed, and so would produce the same series of numbers
   each time a program was run. If you needed less deterministic behaviors, you
   called srand to set up a less predictable seed.
   
   Newer Rubys (Rubies?) have a different behavior. If rand is called without a
   prior call to srand, Ruby will generate its own random(ish) seed. Successive
   runs of a program that does not use srand will generate different sequences of
   random numbers. To get the old, predictable, behavior (perhaps for testing),
   call srand with a constant seed. 

9. Changed by: dag@janrain.com
   Changed at: Thu 05 Jun 2008 17:21:31
   Branch: 2.x.x
   Revision: 20080606001955-bc242-d76b86a1eb216a8068a3738869be4c94d1869c97.gz
   
   Changed files:

   • examples/rails_openid/app/controllers/consumer_controller.rb
   Comments:

   rails_openid example: fix exception with empty identifier
   

10. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Fri 13 Jun 2008 14:26:26
    Branch: 2.x.x
    Revision: 20080613211804-04611-f2ecadc319a13a75a6fc3f4a6d72171f2437b6cf.gz
    
    Changed files:

    • lib/openid/yadis/xrds.rb
    Comments:

    xrds.rb: fix stray colon
    

11. Changed by: cygnus@janrain.com
    Changed at: Wed 11 Jun 2008 11:26:21
    Branch: 2.x.x
    Revision: 20080611180811-32594-22b633f014dc67357e470fb266bdb46683e0a402.gz
    
    Changed files:

    • test/data/trustroot.txt
    Comments:

    Add test cases for trust roots with non-ASCII characters in path or hostname
    

12. Changed by: dag@janrain.com
    Changed at: Fri 06 Jun 2008 11:00:10
    Branch: 2.x.x
    Revision: 20080606175918-bc242-38531de4c8e4cd7649afee7dc47d50e6e35953d1.gz
    
    Changed files:

    • test/test_server.rb
    Comments:

    fix test failure from old patch & namespace changes
    

13. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 25 Jun 2008 17:07:07
    Branch: 2.x.x
    Revision: 20080626000635-04611-0ffa476ea02bffa9c31fff6c63fab1db80da32ee.gz
    
    Changed files:

    • lib/openid/trustroot.rb
    Comments:

    TrustRoot.check_sanity: don't fail if the trust root is not parseable
    

14. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Fri 06 Jun 2008 15:08:48
    Branch: 2.x.x
    Revision: 20080606220817-04611-d5d5e3eb6c73d1e96e160a83c210d8c6a2e32c8d.gz
    
    Changed files:

    • lib/openid/extension.rb
    • test/test_extension.rb
    Comments:

    Do not send namespace aliases for extensions with OpenID 1 messages that we create
    

15. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 25 Jun 2008 14:14:46
    Branch: 2.x.x
    Revision: 20080625211405-04611-c4ece128388b795a5841c56c5b93736af392035d.gz
    
    Changed files:

    • lib/openid.rb
    Comments:

    move OpenID::VERSION definition in openid.rb, for #256
    

16. Changed by: dag@janrain.com
    Changed at: Thu 05 Jun 2008 13:15:36
    Branch: 2.x.x
    Revision: 20080605201336-bc242-223dfbc51e7339e6d985bf61370593344a41d9d6.gz
    
    Changed files:

    • test/test_server.rb
    Comments:

    Add 2 missing trust root tests
    

17. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Fri 06 Jun 2008 07:57:28
    Branch: 2.x.x
    Revision: 20080606145055-04611-cf1ca973a3b138c77d5cf8582b3d4310c8b94979.gz
    
    Changed files:

    • lib/openid/message.rb
    Comments:

    Message.is_openid1: add parens to quiet warning
    

18. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 04 Jun 2008 12:02:34
    Branch: 2.x.x
    Revision: 20080604185809-04611-d5ebdb19739f3cd01218434cc41428e29ad2f3e1.gz
    
    Changed files:

    • test/test_server.rb
    Comments:

    test ProtocolError.which_encoding in no_message test
    

19. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 04 Jun 2008 11:50:33
    Branch: 2.x.x
    Revision: 20080604185010-04611-eb801b413e719cbfefc0203433d87ff32c3a4b0d.gz
    
    Changed files:

    • lib/openid/server.rb
    Comments:

    typo
    

20. Changed by: dag@janrain.com
    Changed at: Mon 02 Jun 2008 17:07:21
    Branch: 2.x.x
    Revision: 20080602235521-bc242-773626299a566f52cc6a88bccaa430809638ebf9.gz
    
    Changed files:

    • lib/openid/consumer/idres.rb
    • test/test_idres.rb
    Comments:

    Normalize return_to URI before checking
    

21. Changed by: cygnus@janrain.com
    Changed at: Thu 05 Jun 2008 17:05:37
    Branch: 2.x.x
    Revision: 20080606000400-32594-1663a7ab02d54d927d00d0e7e403c2409d3d2e2c.gz
    
    Changed files:

    • examples/rails_openid/app/controllers/consumer_controller.rb
    Comments:

    Use FileStore in rails demo RP
    

22. Changed by: dag@janrain.com
    Changed at: Thu 05 Jun 2008 16:56:32
    Branch: 2.x.x
    Revision: 20080605235534-bc242-664fef66727726aa69073d4ececa6ba147e54d45.gz
    
    Changed files:

    • lib/openid/message.rb
    • test/test_idres.rb
    • test/test_message.rb
    • test/test_server.rb
    Comments:

    message: allow two values for OPENID1_NS
    

23. Changed by: cygnus@janrain.com
    Changed at: Thu 05 Jun 2008 16:51:00
    Branch: 2.x.x
    Revision: 20080605234829-32594-aaf76a3f888de70a8d2b2133004218f076f5c0ec.gz
    
    Changed files:

    • CHANGES-2.1.0
    Comments:

    Add CHANGES-2.1.0
    

24. Changed by: dag@janrain.com
    Changed at: Wed 04 Jun 2008 17:15:45
    Branch: 2.x.x
    Revision: 20080605001438-bc242-93cfb7eee8b8813f8bb2bae26c5aa1437a5b0a1e.gz
    
    Changed files:

    • test/data/trustroot.txt
    Comments:

    Add trustroot test case for scheme caps normalization
    

25. Changed by: dag@janrain.com
    Changed at: Thu 05 Jun 2008 17:27:57
    Branch: 2.x.x
    Revision: 20080606002655-bc242-138610877eef116c1f2a2dafec61626ca9c7d83a.gz
    
    Changed files:

    • examples/rails_openid/app/controllers/consumer_controller.rb
    Comments:

    Fix the instantiation of the Filesystem store in the rails_openid example
    

26. Changed by: chowells@janrain.com
    Changed at: Thu 10 Jul 2008 16:25:29
    Branch: 2.x.x
    Revision: 20080710232446-05081-a0f39fe4ac868a568ac8524f08e6432359921bc5.gz
    
    Changed files:

    • lib/openid/consumer.rb
    Comments:

    Provide the user_setup_url in the SetupNeededResponse even in OpenID 2
    

27. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Fri 27 Jun 2008 14:21:21
    Branch: 2.x.x
    Revision: 20080627203443-04611-c13136712c6e1e8fac9051f8cc55f76a67ca563e.gz
    
    Changed files:

    • LICENSE
    Comments:

    LICENSE: htmltokenizer is (c) 2004 Ben Giddings
    

28. Changed by: dag@janrain.com
    Changed at: Thu 05 Jun 2008 13:34:11
    Branch: 2.x.x
    Revision: 20080605203014-bc242-56516958964fd7b334aefbac38408c755ba85e7f.gz
    
    Changed files:

    • README
    • examples/README
    Comments:

    Update README and examples/README
    

29. Changed by: dag@janrain.com
    Changed at: Thu 05 Jun 2008 13:53:04
    Branch: 2.x.x
    Revision: 20080605205213-bc242-7793effdf984b8186061c9526904970ae5a3257f.gz
    
    Changed files:

    • UPGRADE
    Comments:

    Add a note about change to name of ca list instance var
    

30. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 04 Jun 2008 14:35:06
    Branch: 2.x.x
    Revision: 20080604210205-04611-e7d78521ef863b042ebaed58b60a322a1a5aad78.gz
    
    Changed files:

    • README
    Comments:

    README: Add /contribute/ URL
    

31. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 25 Jun 2008 13:56:18
    Branch: 2.x.x
    Revision: 20080625205518-04611-92250d0c2ad8a98d7bc96cf76c30528ce4fbe659.gz
    
    Changed files:

    • admin/gettlds.py
    Comments:

    Add admin/gettlds.py to ease updating of TLD list in trust root validation
    

32. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Fri 13 Jun 2008 13:51:02
    Branch: 2.x.x
    Revision: 20080613204158-04611-0bf1395fac1022b3fb8452ae6074eca69666a225.gz
    
    Changed files:

    • lib/openid/yadis/xrds.rb
    Comments:

    Yadis::get_canonical_id: case-insensitive comparison
    
    Porting a patch from =wil:
    
    1. There should only be a single CanonicalID in each XRD (in the latest XRI
    resolution spec), so I made it use the first CID found instead of the last.
    
    2. Use case-insensitive comparison when comparing CanonicalIDs.

33. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Tue 03 Jun 2008 16:41:31
    Branch: 2.x.x
    Revision: 20080603233615-04611-8db2a14e2d8fda62ce4db13bdd8a104458b905da.gz
    
    Changed files:

    • lib/openid/server.rb
    • test/test_server.rb
    Comments:

    server..CheckIDRequest.from_message: raise ProtocolError if claimed_id is provided without identity
    

34. Changed by: cygnus@janrain.com
    Changed at: Thu 05 Jun 2008 17:00:17
    Branch: 2.x.x
    Revision: 20080605235733-32594-dbee5dad68a20c60f053258e3afc8bc69fdb2dca.gz
    
    Changed files:

    • lib/openid/util.rb
    Comments:

    Change OpenID::VERSION to 2.1.0
    

35. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 25 Jun 2008 17:32:10
    Branch: 2.x.x
    Revision: 20080626003126-04611-62f12c2e62a1a87d8438a290db6f0cceb0c4f4db.gz
    
    Changed files:

    • lib/openid/server.rb
    Comments:

    OpenID::Server::CheckIDRequest.answer: document return type
    

36. Changed by: dag@janrain.com
    Changed at: Thu 05 Jun 2008 13:03:32
    Branch: 2.x.x
    Revision: 20080605192353-bc242-7e3ce68324daf0bd0ef4c5348e0f46f3cc0b516d.gz
    
    Changed files:

    • lib/openid/server.rb
    • test/test_server.rb
    Comments:

    server..Decode.decode: make sure ProtocolError has a Message even after InvalidOpenIDNamespace
    

37. Changed by: chowells@janrain.com
    Changed at: Fri 11 Jul 2008 15:54:59
    Branch: 2.x.x
    Revision: 20080711225516-05081-b7e3b90aebc7e79db0923a2294858e90a6e68d6d.gz
    
    Changed files:

    • test/test_idres.rb
    Comments:

    test_idres: hopefully fix buildbot issues on 1.9
    

38. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Tue 03 Jun 2008 16:48:35
    Branch: 2.x.x
    Revision: 20080603234403-04611-57c3b706e0b29ccfad59da5e1a3f015acbf38f5a.gz
    
    Changed files:

    • lib/openid/server.rb
    Comments:

    server..Decoder.default_decoder: more readable error message
    

39. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 25 Jun 2008 16:35:00
    Branch: 2.x.x
    Revision: 20080625233130-04611-770358c6c678e3c4612389d852d2434edaf89c3e.gz
    
    Changed files:

    • lib/openid/kvpost.rb
    Comments:

    Message.from_http_response: accept 206 code
    

40. Changed by: Kevin Turner <kevin@janrain.com>
    Changed at: Wed 11 Jun 2008 15:29:31
    Branch: 2.x.x
    Revision: 20080611222412-04611-1247a77876177cf52219b434cd19b39a3294cd93.gz
    
    Changed files:

    • lib/openid/consumer/discovery.rb
    • lib/openid/yadis/discovery.rb
    Comments:

    Accept response code 206 from fetcher results.  Fixes #260